Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating bookmark immediately after save #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdamVig
Copy link

@AdamVig AdamVig commented Dec 6, 2024

Currently, after saving a bookmark, there is no way to submit updates
without closing the extension dialog and reopening it. This makes it
possible to submit updates to the bookmark without reopening the
extension.

Also:

  • Shows the star badge on the extension icon immediately after a
    successful save
  • Displays the "This URL is already bookmarked." message after the
    save success state resets

Similar to the logic in the closed pull request #46. May address #13.

Currently, after saving a bookmark, there is no way to submit updates
without closing the extension dialog and reopening it. This makes it
possible to submit updates to the bookmark without reopening the
extension.

Also:
- Shows the star badge on the extension icon immediately after a
successful save
- Displays the "This URL is already bookmarked." message after the
save success state resets

Similar to the logic in the closed pull request sissbruecker#46. May address sissbruecker#13.
@AdamVig AdamVig force-pushed the allow-update-afer-save branch from e6fb518 to d385319 Compare December 6, 2024 02:24
@AdamVig AdamVig marked this pull request as ready for review December 6, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant