Convert minunit.h to be ANSI C89 compliant (range comments and variable ... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le declarations at beginning of scope.
|
Merged. About making the dependencies optional, I don't want to make the implementation more complicated now, the library is so small that one can fork and customize it as needed. In any case if you come up with a nice solution I will be happy to merge it. |
siu
added a commit
that referenced
this pull request
Jan 13, 2015
Convert minunit.h to be ANSI C89 compliant (range comments and variable ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...declarations at beginning of scope.
I have a need to use minunit.h in a source tree that may be compiled using compilers that do not recognize extensions to C89 (yes they exist :P), so I made minunit.h compile successfully when gcc's -pedantic-errors is enabled.
However, the C compiler must still provide the C99 snprintf, which is fine for now. There exist ANSI C89 snprintf implementations which I could use in the worst case.
Ideally, I'd like to make the dependencies on the stdlib and timer optional, where users must provide a logging function (replace printf) and timer (also optional if it weren't for the #error directive in minunit.h) if one does not exist.