Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picto move svgs to assets #324

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

stefan-laux
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Moved SVG's from SCSS file to assets folder that way the picto chunk size gets minimized from 500kb to 5kb or smaller.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@stefan-laux stefan-laux self-assigned this Jan 22, 2025
@stefan-laux stefan-laux added the enhancement New feature or request label Jan 22, 2025
@colinscz
Copy link
Collaborator

@stefan-laux the tests seem to still fail, can you please fix them?

@stefan-laux
Copy link
Collaborator Author

should be fixed @colinscz

Copy link
Collaborator

@colinscz colinscz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ‘πŸ½

@colinscz colinscz merged commit 931e1d7 into main Feb 3, 2025
1 check passed
@colinscz colinscz deleted the feature/picto-move-svgs-to-assets branch February 3, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants