SPR1-1207: Support wsclean sources #78
Open
+152
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed constructor signature for katpoint.Target
|
I haven't looked at this in great detail yet, but I would rather not add a new body / coordinate type for what is essentially a flux model. You might have been inspired by the May I suggest ska-sa/katsdpcal#25 as inspiration instead. My plan has been to move this functionality into katpoint all along. There is also the slightly thorny issue of katpoint v0 vs katpoint v1. Ideally this should go into v1, but porting it across should be reasonable if it remains within |
ludwigschwardt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow the importing of 'wsclean'/BBSelfcal -format specified sources into katpoint.