Add user profile, add email getter and setter, other minor changes #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yavrsky
approved these changes
Oct 2, 2024
TheGreatAxios
approved these changes
Oct 2, 2024
| @@ -1,6 +1,7 @@ | |||
| @import './variables'; | |||
| @import './styles/components'; | |||
| @import './styles/chip'; | |||
| @import './styles/ProfileModal'; | |||
There was a problem hiding this comment.
Should this be imported directly into ./src/profile/ProfileModal.tsx directly?
There was a problem hiding this comment.
Broader note that it would be for technical debt reduction to align all CSS styles to camelCase instead of kabob-case
There was a problem hiding this comment.
agree, much needed refactoring, will work on this one
There was a problem hiding this comment.
Same note as above, would be great to have these all be either camelCase or some form of camelCase with BEM to ensure a standard but it's just a tech debt notice
DmytroNazarenko
approved these changes
Oct 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: