Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various checks issues #1126

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix various checks issues #1126

merged 2 commits into from
Nov 4, 2024

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Nov 1, 2024

Changes

  • Fix multiple checks api issues related to repair, process and schains data

Testing

  • Fixed unit tests
  • Tested on local network

Performance

  • No performance related changes were introduced

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.23%. Comparing base (34ee3f6) to head (d8c2b7b).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
web/routes/health.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
- Coverage    83.27%   83.23%   -0.05%     
===========================================
  Files          102      102              
  Lines         6296     6303       +7     
===========================================
+ Hits          5243     5246       +3     
- Misses        1053     1057       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger marked this pull request as ready for review November 1, 2024 19:55
@badrogger badrogger merged commit 63d8319 into develop Nov 4, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants