Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not increase failed_rpc_count when Rpc status is False #1143

Draft
wants to merge 2 commits into
base: v2.10.x
Choose a base branch
from
Draft

Do not increase failed_rpc_count when Rpc status is False #1143

wants to merge 2 commits into from
+276 −286

Conversation

badrogger
Copy link
Contributor

@badrogger badrogger commented Jan 29, 2025 •
edited
Loading

Changes

  • Do not increase failed_rpc_count while Rpc status is false in skaled.status file

Performance

  • No performance related changes were introduced

Testing

  • Modified unit tests
  • Tested on local network

@badrogger badrogger changed the title Do not increase failed_rpc_counter when Rpc status is False Do not increase failed_rpc_count when Rpc status is False Jan 29, 2025
@badrogger badrogger linked an issue Jan 29, 2025 that may be closed by this pull request
Skaled not starts from the catchup for a long time after recreation of skaled-container skalenetwork/skaled#1373
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytrotkk dmytrotkk Awaiting requested review from dmytrotkk dmytrotkk will be requested when the pull request is marked ready for review dmytrotkk is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex will be requested when the pull request is marked ready for review kladkogex is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaled not starts from the catchup for a long time after recreation of skaled-container
1 participant
@badrogger