IS 902 handle wrong snapshot block number request for signatures

skalenetwork · Jan 16, 2024 · aab2420 · aab2420
1 parent 9431fab
commit aab2420
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/libweb3jsonrpc/Skale.cpp b/libweb3jsonrpc/Skale.cpp
@@ -159,7 +159,7 @@ nlohmann::json Skale::impl_skale_getSnapshot( const nlohmann::json& joRequest, C
     // TODO check
     unsigned blockNumber = joRequest["blockNumber"].get< unsigned >();
     if ( blockNumber != m_client.getLatestSnapshotBlockNumer() ) {
-        joResponse["error"] = "Wrong snapshot block number requested.";
+        joResponse["error"] = "Invalid snapshot block number requested - it might be deleted.";
         return joResponse;
     }
 
@@ -370,6 +370,11 @@ Json::Value Skale::skale_getSnapshotSignature( unsigned blockNumber ) {
     if ( chainParams.nodeInfo.keyShareName.empty() || chainParams.nodeInfo.sgxServerUrl.empty() )
         throw jsonrpc::JsonRpcException( "Snapshot signing is not enabled" );
 
+    if ( blockNumber != this->m_client.getLatestSnapshotBlockNumer() ) {
+        throw jsonrpc::JsonRpcException(
+            "Invalid snapshot block number requested - it might be deleted." );
+    }
+
     try {
         dev::h256 snapshot_hash = this->m_client.getSnapshotHash( blockNumber );
         if ( !snapshot_hash )