Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth and skaled trace inconsistencies #1767

Closed
oleksandrSydorenkoJ opened this issue Dec 18, 2023 · 3 comments · Fixed by #1804
Closed

geth and skaled trace inconsistencies #1767

oleksandrSydorenkoJ opened this issue Dec 18, 2023 · 3 comments · Fixed by #1804
Assignees
Labels
bug Something isn't working epic:archive-node

Comments

@oleksandrSydorenkoJ
Copy link

Preconditions
Active chains
Archival node on Skale chain
Geth node on Goerly with debug mode
Address with 1 Sfuel, 1 GoerlyETH and with Whitelist deployer role
Contract to deploy: Example ERC20

Versions
skalenetwork/schain:3.17.2-develop.2-historic

Steps to reproduce

  1. Send transaction contract deployment to Schain via any tool ( Hardhat, web3py, Remix)
  2. Wait until the transaction is mined with status 0x1 (success) and save the transaction hash
  3. Send transaction contract deployment to Goerly via any tool ( Hardhat, web3py, Remix)
  4. Wait until the transaction is mined with status 0x1 (success) and save the transaction hash
  5. Send debug_traceTransaction methods with tx_hash from step 2 to Archival node on Skale chain
  6. Send debug_traceTransaction methods with tx_hash from step 4 to Geth on Goerly
curl <http endpoint of Goerly or Skale chain>  -X POST  -H "Content-Type: application/json"  --data '{"method":"debug_traceTransaction","params":["0x49a3d705bcc39269e8f09666f7607abd715e4194ad23d8d23ee92e45d52272e4",{"tracer":"callTracer"}],"id":1,"jsonrpc":"2.0"}'

Expected state:
Results of the 5th and 6th steps should be the same, except gas and gasPrice (dynamic values)

Actual state
The archival node on Skale chain doesn't return "input" and "to" fields on debug_traceTransaction call

Detailed comparison
debug_traceTransaction_difference_with_goerly.txt

@oleksandrSydorenkoJ oleksandrSydorenkoJ added bug Something isn't working epic:archive-node labels Dec 18, 2023
@PolinaKiporenko PolinaKiporenko moved this to Ready For Pickup in SKALE Engineering 🚀 Dec 18, 2023
@kladkogex kladkogex linked a pull request Dec 27, 2023 that will close this issue
@kladkogex kladkogex removed a link to a pull request Dec 27, 2023
kladkogex added a commit that referenced this issue Jan 23, 2024
kladkogex added a commit that referenced this issue Jan 23, 2024
kladkogex added a commit that referenced this issue Jan 23, 2024
kladkogex added a commit that referenced this issue Jan 23, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Jan 24, 2024
kladkogex added a commit that referenced this issue Jan 24, 2024
kladkogex added a commit that referenced this issue Jan 24, 2024
kladkogex added a commit that referenced this issue Jan 26, 2024
kladkogex added a commit that referenced this issue Jan 26, 2024
kladkogex added a commit that referenced this issue Jan 26, 2024
kladkogex added a commit that referenced this issue Jan 26, 2024
kladkogex added a commit that referenced this issue Jan 26, 2024
kladkogex added a commit that referenced this issue Jan 26, 2024
kladkogex added a commit that referenced this issue Jan 28, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
@kladkogex kladkogex linked a pull request Feb 2, 2024 that will close this issue
@kladkogex kladkogex changed the title debug_traceTransaction with "callTracer" tracer doesn't return "input" and "to" fields in response geth and skaled trace inconsistencies Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
kladkogex added a commit that referenced this issue Feb 2, 2024
@PolinaKiporenko PolinaKiporenko moved this from In Progress to Code Review in SKALE Engineering 🚀 Feb 5, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Mar 5, 2024
@oleksandrSydorenkoJ
Copy link
Author

Verified on skalenetwork/schain:3.18.1-develop.0-historic


 curl http://localhost:10131 \
-X POST \
-H "Content-Type: application/json" \
--data '{"method":"debug_traceTransaction","params":["0x254c9a4aeef1b40916ec608b4a181f125f9def9b6dac2ac24eb04b62a2f8f286", {"tracer": "callTracer"}], "id":1,"jsonrpc":"2.0"}'
{"id":1,"jsonrpc":"2.0","result":{"from":"0x863f816036e3cbba90855196c9d1e339fcff1650","gas":"0x2af40","gasUsed":"0x19062","input":"0x56b8c7240000000000000000000000007cef6369dfd5377d823a2c65b3c2de740d52a5b400000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000008366393063613830343832303136623833303138366130393438386664356530313037383632396363313934633933336439363331623934342020202020202020202020202020386665313062316438306239306334343764393330313962303030303033306365653739333865396562613265393132313162373862333239653236320000000000000000000000000000000000000000000000000000000000","output":"0x0000000000000000000000000000000000000000000000000000000000000001","to":"0xef6dbcc0dd16775ca930e8bdfe33f6d7a07b9a1f","type":"CALL","value":"0x0"}}

@PolinaKiporenko
Copy link
Contributor

3.18.1-beta.0

@PolinaKiporenko PolinaKiporenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 May 2, 2024
@oleksandrSydorenkoJ
Copy link
Author

Verified on Legacy network
Version: skalenetwork/schain:3.18.1-beta.0-historic
skale_schain_these-long-sadalsuud
Transaction token transfer 0xcb49df24a751049963245c259edbf8e4a75d60a487adb0c73266c9d561c53983

curl http://localhost:10195/   -X POST -H "Content-Type: application/json" --data '{"method":"debug_traceTransaction","params":["0xcb49df24a751049963245c259edbf8e4a75d60a487adb0c73266c9d561c53983", {"tracer": "callTracer"}], "id":1,"jsonrpc":"2.0"}'
{"id":1,"jsonrpc":"2.0","result":{"from":"0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659","gas":"0xee6b280","gasUsed":"0x6fc8a","input":"0x608060405234801561001057600080fd5b5060405161082338038061082383398101604081905261002f916101b9565b8251610042906000906020860190610074565b508151610056906001906020850190610074565b50600281905533600090815260036020526040902055506102769050565b82805461008090610225565b90600052602060002090601f0160209004810192826100a257600085556100e8565b82601f106100bb57805160ff19168380011785556100e8565b828001600101855582156100e8579182015b828111156100e85782518255916020019190600101906100cd565b506100f49291506100f8565b5090565b5b808211156100f457600081556001016100f9565b600082601f83011261011e57600080fd5b81516001600160401b038082111561013857610138610260565b604051601f8301601f19908116603f0116810190828211818310171561016057610160610260565b8160405283815260209250868385880101111561017c57600080fd5b600091505b8382101561019e5785820183015181830184015290820190610181565b838211156101af5760008385830101525b9695505050505050565b6000806000606084860312156101ce57600080fd5b83516001600160401b03808211156101e557600080fd5b6101f18783880161010d565b9450602086015191508082111561020757600080fd5b506102148682870161010d565b925050604084015190509250925092565b600181811c9082168061023957607f821691505b6020821081141561025a57634e487b7160e01b600052602260045260246000fd5b50919050565b634e487b7160e01b600052604160045260246000fd5b61059e806102856000396000f3fe608060405234801561001057600080fd5b50600436106100625760003560e01c806306fdde031461006757806318160ddd1461008557806340c10f191461009c57806356b8c724146100b157806370a08231146100d457806395d89b41146100f4575b600080fd5b61006f6100fc565b60405161007c9190610483565b60405180910390f35b61008e60025481565b60405190815260200161007c565b6100af6100aa366004610341565b61018a565b005b6100c46100bf36600461036b565b6101d4565b604051901515815260200161007c565b61008e6100e236600461031f565b60036020526000908152604090205481565b61006f6102f6565b60008054610109906104e6565b80601f0160208091040260200160405190810160405280929190818152602001828054610135906104e6565b80156101825780601f1061015757610100808354040283529160200191610182565b820191906000526020600020905b81548152906001019060200180831161016557829003601f168201915b505050505081565b6001600160a01b038216600090815260036020526040812080548392906101b29084906104b7565b9250508190555080600260008282546101cb91906104b7565b90915550505050565b3360009081526003602052604081205483111561022e5760405162461bcd60e51b8152602060048201526014602482015273496e73756666696369656e742062616c616e636560601b604482015260640160405180910390fd5b60005b600681101561029e5733600090815260036020526040812080548692906102599084906104cf565b90915550506001600160a01b038516600090815260036020526040812080548692906102869084906104b7565b9091555081905061029681610521565b915050610231565b50836001600160a01b0316336001600160a01b03167fcd6e659e4c2e75c3bfe47fecaccf39aeb368116a0ee52afb532e07f6cba6c0d185856040516102e4929190610496565b60405180910390a35060019392505050565b60018054610109906104e6565b80356001600160a01b038116811461031a57600080fd5b919050565b60006020828403121561033157600080fd5b61033a82610303565b9392505050565b6000806040838503121561035457600080fd5b61035d83610303565b946020939093013593505050565b60008060006060848603121561038057600080fd5b61038984610303565b925060208401359150604084013567ffffffffffffffff808211156103ad57600080fd5b818601915086601f8301126103c157600080fd5b8135818111156103d3576103d3610552565b604051601f8201601f19908116603f011681019083821181831017156103fb576103fb610552565b8160405282815289602084870101111561041457600080fd5b8260208601602083013760006020848301015280955050505050509250925092565b6000815180845260005b8181101561045c57602081850181015186830182015201610440565b8181111561046e576000602083870101525b50601f01601f19169290920160200192915050565b60208152600061033a6020830184610436565b8281526040602082015260006104af6040830184610436565b949350505050565b600082198211156104ca576104ca61053c565b500190565b6000828210156104e1576104e161053c565b500390565b600181811c908216806104fa57607f821691505b6020821081141561051b57634e487b7160e01b600052602260045260246000fd5b50919050565b60006000198214156105355761053561053c565b5060010190565b634e487b7160e01b600052601160045260246000fd5b634e487b7160e01b600052604160045260246000fdfea26469706673582212205393945b341e6ee5bb89c350656b19b8439867683ac45c09491327bbfba1d64864736f6c63430008060033000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000056bc75e2d63100000000000000000000000000000000000000000000000000000000000000000000b746573745141546f6b656e00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000035141540000000000000000000000000000000000000000000000000000000000","output":"0x608060405234801561001057600080fd5b50600436106100625760003560e01c806306fdde031461006757806318160ddd1461008557806340c10f191461009c57806356b8c724146100b157806370a08231146100d457806395d89b41146100f4575b600080fd5b61006f6100fc565b60405161007c9190610483565b60405180910390f35b61008e60025481565b60405190815260200161007c565b6100af6100aa366004610341565b61018a565b005b6100c46100bf36600461036b565b6101d4565b604051901515815260200161007c565b61008e6100e236600461031f565b60036020526000908152604090205481565b61006f6102f6565b60008054610109906104e6565b80601f0160208091040260200160405190810160405280929190818152602001828054610135906104e6565b80156101825780601f1061015757610100808354040283529160200191610182565b820191906000526020600020905b81548152906001019060200180831161016557829003601f168201915b505050505081565b6001600160a01b038216600090815260036020526040812080548392906101b29084906104b7565b9250508190555080600260008282546101cb91906104b7565b90915550505050565b3360009081526003602052604081205483111561022e5760405162461bcd60e51b8152602060048201526014602482015273496e73756666696369656e742062616c616e636560601b604482015260640160405180910390fd5b60005b600681101561029e5733600090815260036020526040812080548692906102599084906104cf565b90915550506001600160a01b038516600090815260036020526040812080548692906102869084906104b7565b9091555081905061029681610521565b915050610231565b50836001600160a01b0316336001600160a01b03167fcd6e659e4c2e75c3bfe47fecaccf39aeb368116a0ee52afb532e07f6cba6c0d185856040516102e4929190610496565b60405180910390a35060019392505050565b60018054610109906104e6565b80356001600160a01b038116811461031a57600080fd5b919050565b60006020828403121561033157600080fd5b61033a82610303565b9392505050565b6000806040838503121561035457600080fd5b61035d83610303565b946020939093013593505050565b60008060006060848603121561038057600080fd5b61038984610303565b925060208401359150604084013567ffffffffffffffff808211156103ad57600080fd5b818601915086601f8301126103c157600080fd5b8135818111156103d3576103d3610552565b604051601f8201601f19908116603f011681019083821181831017156103fb576103fb610552565b8160405282815289602084870101111561041457600080fd5b8260208601602083013760006020848301015280955050505050509250925092565b6000815180845260005b8181101561045c57602081850181015186830182015201610440565b8181111561046e576000602083870101525b50601f01601f19169290920160200192915050565b60208152600061033a6020830184610436565b8281526040602082015260006104af6040830184610436565b949350505050565b600082198211156104ca576104ca61053c565b500190565b6000828210156104e1576104e161053c565b500390565b600181811c908216806104fa57607f821691505b6020821081141561051b57634e487b7160e01b600052602260045260246000fd5b50919050565b60006000198214156105355761053561053c565b5060010190565b634e487b7160e01b600052601160045260246000fd5b634e487b7160e01b600052604160045260246000fdfea26469706673582212205393945b341e6ee5bb89c350656b19b8439867683ac45c09491327bbfba1d64864736f6c63430008060033","to":"0x8722eb776a5d9a2ffd914648381fe2daf80c7add","type":"CREATE","value":"0x0"}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic:archive-node
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants