-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1767 fix geth skaled trace inconsistencies #1804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUGGESTIONS BEFORE MERGE:
|
PolinaKiporenko
modified the milestones:
.SKALE 2.3.1 (Archive node),
SKALE 2.3.1 (Archive node)
Feb 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.17.2 #1804 +/- ##
===========================================
- Coverage 42.78% 42.69% -0.09%
===========================================
Files 392 392
Lines 57121 57235 +114
===========================================
- Hits 24440 24439 -1
- Misses 32681 32796 +115 |
DmytroNazarenko
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a number of inconsistencies between skaled geth, included the one reported by Sasha
Added lots of new test traces to trace.ts,
in particular traces for contract deployment both as a standalone transaction and
when created from a different contract.
All tests run as part of github actions