Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1767 fix geth skaled trace inconsistencies #1804

Merged
merged 87 commits into from
Feb 26, 2024
Merged

Conversation

kladkogex
Copy link
Collaborator

Fixed a number of inconsistencies between skaled geth, included the one reported by Sasha

Added lots of new test traces to trace.ts,

in particular traces for contract deployment both as a standalone transaction and
when created from a different contract.

All tests run as part of github actions

@kladkogex kladkogex added this to the SKALE 2.3.1 (Archive node) milestone Feb 2, 2024
@kladkogex kladkogex self-assigned this Feb 2, 2024
@kladkogex kladkogex linked an issue Feb 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0.46512% with 214 lines in your changes are missing coverage. Please review.

Project coverage is 42.69%. Comparing base (3e8b8fe) to head (dbac33c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.2    #1804      +/-   ##
===========================================
- Coverage    42.78%   42.69%   -0.09%     
===========================================
  Files          392      392              
  Lines        57121    57235     +114     
===========================================
- Hits         24440    24439       -1     
- Misses       32681    32796     +115     

@kladkogex kladkogex merged commit 9de940a into v3.17.2 Feb 26, 2024
6 of 8 checks passed
@kladkogex kladkogex deleted the 1767_tracer_fields branch February 26, 2024 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geth and skaled trace inconsistencies
3 participants