Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix net_version test #1811

Closed
DmytroNazarenko opened this issue Feb 12, 2024 · 1 comment · Fixed by #1814
Closed

Fix net_version test #1811

DmytroNazarenko opened this issue Feb 12, 2024 · 1 comment · Fixed by #1814
Assignees
@dimalit
Labels
bug Something isn't working Technical debt
Milestone
SKALE 2.3.1 (Arch...

Comments

@DmytroNazarenko
Copy link
Collaborator

Unit test in skaled jsonrpc_netVersion randomly fails on check

BOOST_CHECK_EQUAL( version, "65535" );

Need to fix it to make all tests passed on Github Actions
@DmytroNazarenko DmytroNazarenko added bug Something isn't working Technical debt labels Feb 12, 2024
@DmytroNazarenko DmytroNazarenko added this to the SKALE 2.3 milestone Feb 12, 2024
@DmytroNazarenko DmytroNazarenko linked a pull request Feb 12, 2024 that will close this issue
Enhancement/sync node broadcast txs #1651
Merged
@DmytroNazarenko DmytroNazarenko removed a link to a pull request Feb 12, 2024
Enhancement/sync node broadcast txs #1651
Merged
@dimalit dimalit linked a pull request Feb 13, 2024 that will close this issue
SKALED-1811 Fix net_version call error #1814
Merged
@DmytroNazarenko DmytroNazarenko moved this from Done to Code Review in SKALE Engineering 🚀 Feb 15, 2024
@DmytroNazarenko DmytroNazarenko moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Feb 23, 2024
@PolinaKiporenko
Copy link
Contributor

3.18.1-beta.0

@PolinaKiporenko PolinaKiporenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 May 2, 2024
@DmytroNazarenko DmytroNazarenko moved this from Merged To Release Candidate to Done in SKALE Engineering 🚀 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimalit dimalit

Labels
bug Something isn't working Technical debt
Projects
SKALE Engineering 🚀
Archived in project
Milestone
SKALE 2.3.1 (Archive node)
Development

Successfully merging a pull request may close this issue.

SKALED-1811 Fix net_version call error skalenetwork/skaled
3 participants
@dimalit @DmytroNazarenko @PolinaKiporenko