Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALED-1811 Fix net_version call error #1814

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Feb 13, 2024

Unit test jsonrpc_netVersion was failing, not it works.
Root cause: ChainParams was held by reference in class Net, it caused it to point to freed memory. Now it's held by value.

@dimalit dimalit linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.78%. Comparing base (4e5ad12) to head (20dd548).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           v3.17.2    #1814   +/-   ##
========================================
  Coverage    42.78%   42.78%           
========================================
  Files          392      392           
  Lines        57121    57121           
========================================
  Hits         24439    24439           
  Misses       32682    32682           

@DmytroNazarenko DmytroNazarenko merged commit 3e8b8fe into v3.17.2 Feb 23, 2024
8 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bug/SKALED-1811-broken-net_version branch February 23, 2024 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix net_version test
3 participants