Bug/is 869 transaction duplicates #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUGGESTIONS BEFORE MERGE:
|
DmytroNazarenko
approved these changes
Nov 6, 2023
kladkogex
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historic node needs to ignore invalid transactions when asked through JSON-RPC. It checks if transaction is invalid by looking for gasUsed=0 in it's receipt. But in the case, if invalid transaction was resubmitted and become valid in another block - it starts to appear as "valid" for historic node. To fix this, we compare transaction's block in it's receipt with original block number, If they are different - then transaction should be considered invalid still.
Tested by Sasha1 on QA network.