1664 Implement tracing #1734
Merged
1664 Implement tracing #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed into 1664_eth_trace_current
DmytroNazarenko
requested changes
Dec 11, 2023
| @@ -60,7 +60,7 @@ If you have already cloned the repo and forgot to pass `--recurse-submodules`, e | |||
| sudo apt update | |||
| sudo apt install autoconf build-essential cmake libprocps-dev libtool texinfo wget yasm flex bison btrfs-progs python3 python3-pip gawk git vim doxygen | |||
| sudo apt install make build-essential cmake pkg-config libgnutls28-dev libssl-dev unzip zlib1g-dev libgcrypt20-dev docker.io gcc-9 g++-9 gperf clang-format-11 gnutls-dev | |||
| sudo apt install nettle-dev libhiredis-dev redis-server google-perftools libgoogle-perftools-dev lcov | |||
| sudo apt install nettle-dev libhiredis-dev redis-server google-perftools libgoogle-perftools-dev lcov sudo apt-get install libv8-dev | |||
There was a problem hiding this comment.
Please, fix the typo
Comment on lines
+138
to
+139
| auto b = ( uint32_t ) _vm->getStackElement( 0 ); | ||
| auto s = ( uint32_t ) _vm->getStackElement( 1 ); |
There was a problem hiding this comment.
Please, use more descriptive names for b & s
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
The documentation for this feature is provided here:
https://github.com/skalenetwork/skaled/blob/1664_eth_trace_current/docs/tracing.md
Tests
An automated test that tests tracing has been added to
test/historicstate/hardhat/scripts/trace.ts
The test deploys a sample smart contract and tests all tracers.
The test runs as part of Github Actions test.yml