Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

813 eth sync #1738

Merged
merged 4 commits into from
Dec 1, 2023
Merged

813 eth sync #1738

merged 4 commits into from
Dec 1, 2023

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Dec 1, 2023

Implementation

The following function has been added to ConsensusEngine class


SyncInfo getSyncInfo();
    

     // return sync information as requested by eth_syncing API of geth
    // if isSyncing is false, all fields will be set to zero.


    struct SyncInfo {
        // sync information as required by eth_syncing API request of geth
        bool isSyncing;
        std::uint64_t startingBlock;
        std::uint64_t currentBlock;
        std::uint64_t highestBlock;
        }
    

What skaled needs to do is to call this function and return the result as API call

Testing

A test that prints SyncInfo has been added to consensus catchup tests.

The tests were manually executed

@kladkogex kladkogex added this to the 2.3 milestone Dec 1, 2023
@kladkogex kladkogex self-assigned this Dec 1, 2023
@kladkogex kladkogex linked an issue Dec 1, 2023 that may be closed by this pull request
@DmytroNazarenko DmytroNazarenko removed this from the 2.3 milestone Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1738 (0aa534f) into v3.18.0 (d301345) will increase coverage by 0.06%.
Report is 11 commits behind head on v3.18.0.
The diff coverage is 81.25%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1738      +/-   ##
===========================================
+ Coverage    45.53%   45.60%   +0.06%     
===========================================
  Files          353      356       +3     
  Lines        51633    51669      +36     
===========================================
+ Hits         23512    23564      +52     
+ Misses       28121    28105      -16     

@kladkogex kladkogex merged commit 1419be9 into v3.18.0 Dec 1, 2023
9 checks passed
@kladkogex kladkogex deleted the 813_eth_sync branch December 1, 2023 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_syncing info
3 participants