-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/1433 cleanup shared space if unsuccessful download #1740
Merged
olehnikolaiev
merged 4 commits into
v3.18.0
from
bug/1433-unlock-shared-space-if-unsuccessful-download
Dec 5, 2023
Merged
Bug/1433 cleanup shared space if unsuccessful download #1740
olehnikolaiev
merged 4 commits into
v3.18.0
from
bug/1433-unlock-shared-space-if-unsuccessful-download
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
December 4, 2023 17:32
SUGGESTIONS BEFORE MERGE:
|
DmytroNazarenko
previously approved these changes
Dec 4, 2023
kladkogex
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a step by step test description, so another person can reproduce the test
…of github.com:skalenetwork/skaled into bug/1433-unlock-shared-space-if-unsuccessful-download
dimalit
approved these changes
Dec 5, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1740 +/- ##
===========================================
- Coverage 45.60% 45.55% -0.05%
===========================================
Files 356 356
Lines 51669 51669
===========================================
- Hits 23564 23540 -24
- Misses 28105 28129 +24 |
kladkogex
approved these changes
Dec 5, 2023
olehnikolaiev
deleted the
bug/1433-unlock-shared-space-if-unsuccessful-download
branch
December 5, 2023 12:40
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1433
tested manually on devnet as following: