Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1433 cleanup shared space if unsuccessful download #1740

Merged

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Dec 4, 2023

fixes #1433

tested manually on devnet as following:

  1. Decrease network performance to 1500 Kb upload/ 3500 Kb Download on node A
  2. Restart any skaled from the node A from the snapshot - skaled on node shouldn't download more than 1 snapshot fragment
  3. Wait for 3 snapshot intervals
  4. Check shared-space datadir

@olehnikolaiev olehnikolaiev changed the base branch from develop to v3.18.0 December 4, 2023 17:32
DmytroNazarenko
DmytroNazarenko previously approved these changes Dec 4, 2023
Copy link
Collaborator

@kladkogex kladkogex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a step by step test description, so another person can reproduce the test

…of github.com:skalenetwork/skaled into bug/1433-unlock-shared-space-if-unsuccessful-download
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1740 (bcc75a5) into v3.18.0 (0aa534f) will decrease coverage by 0.05%.
Report is 1 commits behind head on v3.18.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1740      +/-   ##
===========================================
- Coverage    45.60%   45.55%   -0.05%     
===========================================
  Files          356      356              
  Lines        51669    51669              
===========================================
- Hits         23564    23540      -24     
- Misses       28105    28129      +24     

@kladkogex kladkogex self-requested a review December 5, 2023 12:37
@olehnikolaiev olehnikolaiev merged commit 1c975d5 into v3.18.0 Dec 5, 2023
8 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1433-unlock-shared-space-if-unsuccessful-download branch December 5, 2023 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared space not cleared before downloading new snapshot
4 participants