Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1199 eth syncing #1742

Merged
merged 6 commits into from
Dec 8, 2023
Merged

1199 eth syncing #1742

merged 6 commits into from
Dec 8, 2023

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Dec 5, 2023

fixes #1199

tested manually on devnet as following:

  • run load test
  • turn off one of the nodes
  • wait for 1 hour
  • turn the node back on. the node should catchup the missing blocks
  • check eth_syncing(). it should return something like
> eth.syncing
{
  currentBlock: 158312,
  healedBytecodeBytes: 0,
  healedBytecodes: 0,
  healedTrienodeBytes: 0,
  healedTrienodes: 0,
  healingBytecode: 0,
  healingTrienodes: 0,
  highestBlock: 159200,
  startingBlock: 156449,
  syncedAccountBytes: 0,
  syncedAccounts: 0,
  syncedBytecodeBytes: 0,
  syncedBytecodes: 0,
  syncedStorage: 0,
  syncedStorageBytes: 0
}

via geth or

{"id":73,"jsonrpc":"2.0","result":{"currentBlock":165382,"highestBlock":167451,"startingBlock":165145}}

via json-rpc during catchup and

> eth.syncing
false

via geth or

{"id":73,"jsonrpc":"2.0","result":false}

via json-rpc when catchup is finished.

@olehnikolaiev olehnikolaiev linked an issue Dec 5, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1742 (1af8e4d) into v3.18.0 (bcc75a5) will decrease coverage by 0.02%.
Report is 1 commits behind head on v3.18.0.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1742      +/-   ##
===========================================
- Coverage    45.55%   45.54%   -0.02%     
===========================================
  Files          356      356              
  Lines        51669    51685      +16     
===========================================
  Hits         23540    23540              
- Misses       28129    28145      +16     

@DmytroNazarenko DmytroNazarenko merged commit 2fcb104 into v3.18.0 Dec 8, 2023
6 of 8 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bug/1199-eth-syncing branch December 8, 2023 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled always returns false on the eth_syncing method
3 participants