-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1199 eth syncing #1742
Merged
Merged
1199 eth syncing #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
December 5, 2023 16:34
SUGGESTIONS BEFORE MERGE:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1742 +/- ##
===========================================
- Coverage 45.55% 45.54% -0.02%
===========================================
Files 356 356
Lines 51669 51685 +16
===========================================
Hits 23540 23540
- Misses 28129 28145 +16 |
DmytroNazarenko
approved these changes
Dec 8, 2023
kladkogex
approved these changes
Dec 8, 2023
kladkogex
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1199
tested manually on devnet as following:
eth_syncing()
. it should return something likevia geth or
via json-rpc during catchup and
via geth or
via json-rpc when catchup is finished.