-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTQ rpc call, v3.18.0 again #1776
FTQ rpc call, v3.18.0 again #1776
Conversation
SUGGESTIONS BEFORE MERGE:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v3.18.0 #1776 +/- ##
===========================================
- Coverage 45.56% 45.56% -0.01%
===========================================
Files 358 356 -2
Lines 51807 51762 -45
===========================================
- Hits 23608 23584 -24
+ Misses 28199 28178 -21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, add unit test
- Update description with information about tx sorting
UPD For some reason, test_stop.py::test_double_stop functional test fails on this branch. When trying to reproduce it locally - everything works ok. So, probably, this should be test problem, not build. |
Note: in results, transactions belonging to same sender go together, ordered by nonce increase. In case of FTQ overflow, last transaction from 1st sender will be dropped.
Testing:
1 JsonRpcSuite/mtm_import_future_txs
2 Manual testing sequence:
Example answer:
Example error:
{"error":{"code":-32601,"message":"METHOD_NOT_FOUND: The method being requested is not available on this server"},"id":4,"jsonrpc":"2.0"}