Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/skaled 1693 func tests on both builds #1788

Merged

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Jan 18, 2024

Every time, after building and publishing schain container, we run 'functional tests' with it. Previously, we ran them only on 'historic' build. This PR runs them twice - on normal, then on historic build.

Tested on temporary repository https://github.com/skalenetwork/skaled_tmp/actions/runs/7571061421

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46bbdbd) 45.76% compared to head (bd6fa93) 46.08%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.18.0    #1788      +/-   ##
===========================================
+ Coverage    45.76%   46.08%   +0.31%     
===========================================
  Files          358      358              
  Lines        51878    51878              
===========================================
+ Hits         23742    23906     +164     
+ Misses       28136    27972     -164     

@dimalit dimalit marked this pull request as ready for review January 19, 2024 12:57
@dimalit dimalit linked an issue Jan 19, 2024 that may be closed by this pull request
@olehnikolaiev olehnikolaiev self-requested a review January 19, 2024 15:31
@DmytroNazarenko DmytroNazarenko merged commit fce0fd1 into v3.18.0 Jan 19, 2024
8 of 9 checks passed
@DmytroNazarenko DmytroNazarenko deleted the enhancement/SKALED-1693-func-tests-on-both-builds branch January 19, 2024 15:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run functional tests for both historic and non-historic versions
3 participants