Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize github workflows #1816

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Optimize github workflows #1816

merged 7 commits into from
Feb 15, 2024

Conversation

DmytroNazarenko
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko commented Feb 13, 2024 •
edited
Loading

This PR optimizes github workflows for skaled:

  1. Fixes issue with dependencies setup during parallel run of test.yml and publish.yml workflows
  2. Moves Cancel Previous Runs into build job to improve visibility of PR checks in Github UI
  3. Temporarily removes codecov functionality until it will not be fixed ( Fix codecov  #1763 )
  4. Adds PR template

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@DmytroNazarenko DmytroNazarenko linked an issue Feb 13, 2024 that may be closed by this pull request
Github actions Develop branch build fails #1807
Closed
@DmytroNazarenko DmytroNazarenko marked this pull request as ready for review February 14, 2024 11:53
@DmytroNazarenko DmytroNazarenko merged commit daffaa1 into develop Feb 15, 2024
5 checks passed
@DmytroNazarenko DmytroNazarenko deleted the optimize-github-workflows branch February 15, 2024 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olehnikolaiev olehnikolaiev olehnikolaiev approved these changes

@kladkogex kladkogex kladkogex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github actions Develop branch build fails
3 participants
@DmytroNazarenko @kladkogex @olehnikolaiev