Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1760 inconsistent revert reason #1831

Merged
merged 38 commits into from
Feb 29, 2024
Merged

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Feb 23, 2024

skaled trace would not correctly print revert reason, due to
problems with formatting code

Fixed the problem and also added many tests for revert reason and custom errors

The tests run automatically as part of github actions

@kladkogex kladkogex linked an issue Feb 23, 2024 that may be closed by this pull request
@kladkogex kladkogex self-assigned this Feb 23, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0.62112% with 160 lines in your changes are missing coverage. Please review.

Project coverage is 36.09%. Comparing base (5147506) to head (5683b0a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.2    #1831      +/-   ##
===========================================
- Coverage    42.69%   36.09%   -6.60%     
===========================================
  Files          392      392              
  Lines        57243    57318      +75     
===========================================
- Hits         24440    20691    -3749     
- Misses       32803    36627    +3824     

@kladkogex kladkogex merged commit ecc5124 into v3.17.2 Feb 29, 2024
5 of 8 checks passed
@kladkogex kladkogex deleted the 1760_inconsistent_revert_reason branch February 29, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent revertReason between skaled and geth
3 participants