-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/skaled 1583 patch architecture #1842
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUGGESTIONS BEFORE MERGE:
|
kladkogex
previously approved these changes
Mar 14, 2024
…so SKALED-1851, SKALED-1846
kladkogex
approved these changes
Apr 10, 2024
Superseded by #1868 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1583
Description
Tests
Tests for patches:
JsonRpcSuite/simple_contract
Performance Impact
There can be significant performance impact, as patch activations are evaluated at each block or sometimes even every transaction. This is to be tested separately
Details about changes in code
blockNumber
parameter now need alsocommittedBlockTimestamp
.EVMSchedule
can now be constructed from several patches, and not only taken from pre-defined list as before (ChainOperationParams::evmSchedule
)SealEngine
toChainOperationParams
, andSealEngine
is now unneeded in some places, whereChainOperationParams
suffice - for simplification of architecture. Also it's planned to cut out SealEngine completely.PushZeroPatch
uses boolean field inEVMSchedule
, and generates new EVMSchedule similar to 'fork blocks'libethereum/SchainPatch.h
there are new macros for creation of patches.SchainPatch
class.