Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1774 change hwm limits for zmq broadcast #1849

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

olehnikolaiev
Copy link
Contributor

fixes #1774

Description

Set ZMQ sockets hard limits to 0 to avoid messages being dropped out from the buffer.

Tests

Tested on the network with historic node and 7 core nodes:

run load test and send all transactions to the historic node
wait for some time (30 min is enough)
stop the load
there will be transactions in transaction queue on the historic node (version 3.18) that stuck there. Wait for 5 more minutes and ensure that those transactions will still be there. it means that these transactions were marked as broadcasted but were dropped out of the socket's buffer and therefore weren't received by other nodes.
there will be no stuck transactions on the historic node built on this branch

Performance Impact

Tested on the network with historic node and 7 core nodes:

run load test for ~2 hours on both new and current versions
ram usage on the new version will not be higher than ram usage on the current version (current version - 500 mb usage, new version - 350-400 mb)
Tested on the devnet - 4-node chain

run load test for 24 hours
ram usage is normal, no swap growth

results verified by @oleksandrSydorenkoJ

image
image

kladkogex
kladkogex previously approved these changes Mar 13, 2024
@olehnikolaiev olehnikolaiev merged commit 5452ee7 into v3.19.0 Mar 14, 2024
5 checks passed
@olehnikolaiev olehnikolaiev deleted the bug/1774-change-zmq-broadcast-hwm branch March 14, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@olehnikolaiev olehnikolaiev restored the bug/1774-change-zmq-broadcast-hwm branch June 12, 2024 12:39
@olehnikolaiev olehnikolaiev deleted the bug/1774-change-zmq-broadcast-hwm branch June 12, 2024 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync node doesn't broadcasts transactions when moved them from future tx queue into current tx queue
4 participants