1859 trace failed transaction #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUGGESTIONS BEFORE MERGE:
|
dimalit
approved these changes
Apr 29, 2024
olehnikolaiev
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a check inside the tracer that was checking for each traced op that
the gas cost of the op is less or equal to the remaining gas.
This is not true in case of out of gas revert for the last op recorded in the trace.
In this case the op gas is more than the remaining gas. This causes the revert.
The check was removed.
Also fixed two places in which the trace was not called for an op. Geth always ads an op
to the trace even if the op is not executed due to out of gas or error.
Also fixed the tests to work with the latest geth.
A test case has been added token_revert.ts