806 consensus improvements #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUGGESTIONS BEFORE MERGE:
|
olehnikolaiev
previously approved these changes
May 7, 2024
dimalit
previously approved these changes
May 9, 2024
DmytroNazarenko
previously approved these changes
May 16, 2024
olehnikolaiev
previously approved these changes
May 16, 2024
DmytroNazarenko
approved these changes
May 16, 2024
dimalit
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves consensus performance by more than 50% and reduces network communications drastically (by up to 16 times)
Tests
Existing consensus tests have been run, all show 50%+ improvements in consensus performance
skaled performance tests still need to be run
Docs
A detailed document has been added to detail new consensus spec including the optimized consensus
https://github.com/skalenetwork/skale-consensus/blob/d99a897a9f254a259cdf1b2e991744e779c783b7/docs/consensus-spec.md
Patchtimestamp
fastConsensusPatchTimestamp