Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/skaled 1951 broken all tests #1997

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Sep 19, 2024

Summary: all functionality is fine, minor problems were only in tests.

Changes:

  1. Use ignoreExternalGas() in several places in tests.
  2. Get back Frontier fork (used in some tests).
  3. Disabled stCodeSizeLimit and stCreateTest in BCGeneralStateTests because they require maxCodeSize 0x6000 (and we have 64k).
  4. Fixed CommonJSTests

See also #1998

@dimalit dimalit marked this pull request as ready for review September 19, 2024 15:26
@dimalit dimalit linked an issue Sep 19, 2024 that may be closed by this pull request
olehnikolaiev
olehnikolaiev previously approved these changes Sep 20, 2024
@DmytroNazarenko DmytroNazarenko added this to the SKALE 3.1 milestone Sep 25, 2024
Copy link
Collaborator

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We need to fix these failing tests to ensure that all tests can run successfully:
unknown location(0): fatal error: in "CommonJSTests/test_jsToFixed": std::invalid_argument: Wrong input format: jsToFixed()
unknown location(0): fatal error: in "CommonJSTests/test_jsToInt": std::invalid_argument: Wrong input format: jsToInt()
unknown location(0): fatal error: in "CommonJSTests/test_jsToU256": std::invalid_argument: Wrong input format: jsToInt<>()
  1. Let's integrate these unit tests into our CD pipeline

@olehnikolaiev olehnikolaiev self-requested a review October 2, 2024 12:17
olehnikolaiev
olehnikolaiev previously approved these changes Oct 2, 2024
@olehnikolaiev olehnikolaiev self-requested a review October 3, 2024 16:28
@DmytroNazarenko DmytroNazarenko merged commit 244bcb8 into v3.20.0 Oct 3, 2024
4 of 5 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bug/SKALED-1951-broken-all-tests branch October 3, 2024 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testeth GeneralStateTests fail on develop
3 participants