Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bootstrap.native #2875

Closed
wants to merge 4 commits into from
Closed

Removed bootstrap.native #2875

wants to merge 4 commits into from

Conversation

marekdedic
Copy link
Collaborator

@marekdedic marekdedic commented Oct 14, 2024

Closes #2874

@marekdedic
Copy link
Collaborator Author

marekdedic commented Oct 14, 2024

Je tam docela hrozný hack na skrývání modálů. On totiž Dialog ten modál skrývá tak, že prostě smaže jeho vnitřnosti:

<div n:snippet n:inner-if="$renderModal" class="modal" tabindex="-1" role="dialog">

Ale Bootstrapový Modal se má smazat tak, že na něm zavoláš funkci "hide" - protože šahá i jinam do stránky než jen do svého elementu...

Jestli máte lepší nápad, jak to udělat, budu rád.

@marekdedic marekdedic marked this pull request as ready for review October 14, 2024 20:33
@marekdedic
Copy link
Collaborator Author

Nakonec jsem musel smazat jeden test, který byl tak 50/50 i když jsem tam všude dal wait a scrollování. Jestli někdo chápete líp, jak funguje Codeception, tak si klidně nechám poradit, jak to opravit.

@marekdedic marekdedic requested review from sinacek and juradee October 14, 2024 20:35
@juradee
Copy link
Collaborator

juradee commented Oct 16, 2024

@marekdedic Mám fix od kolegy. Mám udělat MR?

@juradee
Copy link
Collaborator

juradee commented Oct 16, 2024

Respektive udělám ho večer, ať se na to můžeš mrknout.

@marekdedic
Copy link
Collaborator Author

@juradee Fix na co? Ten flaky test? Jestli jo, tak to je super. Buď MR, nebo tady přes "suggest changes" u review... Každopádně na to kouknu rád

@juradee
Copy link
Collaborator

juradee commented Oct 22, 2024

Viz #2876 upraveno jiným způsobem.

@marekdedic marekdedic closed this Oct 30, 2024
@marekdedic marekdedic deleted the no-bsn branch October 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odebrání bootstrap.native
2 participants