Simplified logic with default prop values

skaut · Jun 18, 2024 · c2fd18a · c2fd18a
1 parent 41fbe71
commit c2fd18a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/frontend/src/components/ArticleBox.tsx b/packages/frontend/src/components/ArticleBox.tsx
@@ -36,7 +36,7 @@ export const ArticleBox = ({
     <Paragraph>
       <ReactMarkdown remarkPlugins={[remarkGfm]}>{description}</ReactMarkdown>
     </Paragraph>
-    {(tags ?? []).map((tag) => (
+    {tags.map((tag) => (
       <ColoredTag key={tag}>{tag}</ColoredTag>
     ))}
   </ThinArticle>

diff --git a/packages/frontend/src/components/ExtLink.tsx b/packages/frontend/src/components/ExtLink.tsx
@@ -20,7 +20,7 @@ export const ExtLink = ({
     className={className}
     href={href}
     title={title}
-    {...(targetSelf !== true
+    {...(!targetSelf
       ? {
           target: "_blank",
           rel: "noreferrer noopener",

diff --git a/packages/frontend/src/components/Issue.tsx b/packages/frontend/src/components/Issue.tsx
@@ -18,7 +18,7 @@ export const Issue = ({
     subtitle={issue.project.name}
     subtitleDescription={issue.project["short-description"]}
     subtitleLink={getProjectLink(issue.project)}
-    tags={hideTags !== true ? issue.project.tags : []}
+    tags={!hideTags ? issue.project.tags : []}
     title={issue.title}
   />
 );