Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility (draft) #14

Closed
wants to merge 2 commits into from

Conversation

GabLeRoux
Copy link

@GabLeRoux GabLeRoux commented Apr 20, 2022

Relates to #12

More precisely #12 (comment)

Current pr is in preparation and will be valid only when upstream issue deanishe/alfred-workflow#97 gets solved.

@mcouthon
Copy link

There's a bunch of Python 3 incompatible code in web.py as well.

@GabLeRoux
Copy link
Author

GabLeRoux commented Apr 21, 2022

There's a bunch of Python 3 incompatible code in web.py as well.

https://github.com/skleinei/alfred-confluence/blob/master/src/lib/workflow/web.py

This file is from the following library:
https://github.com/deanishe/alfred-workflow#readme

Hence it would be preferable to use a fix from the library itself. That is why I did not attempt to fix scripts inside src/lib/workflow folder ;)

I've updated issue description to be more specific.

@mcouthon
Copy link

@GabLeRoux check out #15 . I've tested it and it's working for me (didn't verify update workflow, tbh).
If you think it's good enough, you can use it :)

@skleinei
Copy link
Owner

skleinei commented Sep 6, 2022

@mcouthon, @jodosha, and everyone – as mentioned in #15:


Many thanks for your efforts to fix this. I've rewritten Confluence Quicksearch for Alfred to work with Python 3 (and hence macOS 12.3). The new version also requires Alfred 5, because the new version uses Alfreds' new workflow configuration. Also it's not using the Workflow library. Read more: #16

Let me know, if/how the new version works for you.

As a result of this I will close this PR.

@skleinei skleinei closed this Sep 6, 2022
@GabLeRoux GabLeRoux deleted the python3-support branch October 3, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants