feat: Allow recursive type definition #26
Merged
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's say we have the following type:
```typescript
type Chapter = {
title: string
next: Chapter | null
}
```
Here, `Chapter` type is recursive, referencing itself.
Typelizer can generate this kind of type, but currently it tries
to import itself and causes an error.
This commit fixes this issue by ignoring itself from import target.
Note that I added spec for Alba only since that was my case,
but please tell me if I should add more specs for other serializers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say we have the following type:
Here,
Chaptertype is recursive, referencing itself. Typelizer can generate this kind of type, but currently it tries to import itself and causes an error.This PR fixes this issue by ignoring itself from import target.
Note that I added spec for Alba only since that was my case, but please tell me if I should add more specs for other serializers.