[WIP] update database_talker #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
commented
Jun 1, 2023
| results = self.query_images_and_classify(query=query, start_time=start_time, end_time=end_time) | ||
|
|
||
| # no images found | ||
| if len(results) == 0: | ||
| return {'text': '記憶がありません🤯'} |
There was a problem hiding this comment.
@a-ichikura もうちょっとマシな返答テキストがあれば，教えてくれると助かります．
tkmtnt7000
reviewed
Jun 2, 2023
Comment on lines
+385
to
+390
| if parameters['date']: | ||
| startdate = datetime.datetime.strptime(re.sub('\+(\d+):(\d+)$', '+\\1\\2',parameters['date']), "%Y-%m-%dT%H:%M:%S%z") | ||
| duration = datetime.timedelta(hours=24) | ||
| if parameters['date-period']: | ||
| startdate = datetime.datetime.strptime(re.sub('\+(\d+):(\d+)$', '+\\1\\2',parameters['date-period']['startDate']), "%Y-%m-%dT%H:%M:%S%z") | ||
| duration = datetime.datetime.strptime(re.sub('\+(\d+):(\d+)$', '+\\1\\2',parameters['date-period']['endDate']), "%Y-%m-%dT%H:%M:%S%z") - startdate |
There was a problem hiding this comment.
I suspect that this section cause something wrong with searching database????
There was a problem hiding this comment.
Sorry, I misunderstood the problem. This section has no problem.
This is because a long search, such as a 24-hour search, will not return results until the search is completed, unless the number of data matching the condition is equal to the number of limit items.
|
I can almost run this node with Fetch1075 other than the items I pointed out. $ source ~/ros/database_talker_ws/devel/setup.bash
$ roslaunch jsk_robot_startup sample_database_talker.launch
# other terminal
$ rosrun database_talker hoge.py |
|
@tkmtnt7000 このPRってマージしたほうがいい？ |
|
マージしていただけると助かります． |
tkmtnt7000
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update version of jsk-ros-pkg#1388