Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an input path field and a dorp-down menu for devices #70

Closed
wants to merge 1 commit into from

Conversation

R-Abbasi
Copy link
Collaborator

  • Added an input path field, drop-down menu for devices, a button and a text

@R-Abbasi R-Abbasi requested a review from AKMaily December 12, 2023 18:15
@MaxClerkwell
Copy link
Contributor

I tried reviewing the code just now. It is currently quite difficult to go through changes, since there are so many lines marked as changed:
image

We should find a way to have a consistent formatting.
There is a pre-commit-hook for clang format in the repo. But it looks like that hasn't been executed here, or am I mistaken?

@MaxClerkwell
Copy link
Contributor

I am sorry, can you tell me, which issue this is related to?
Maybe we should always put a screenshot of the feature into the pr.
It's really easy for me to get confused sometimes, sorry for that!

@MaxClerkwell
Copy link
Contributor

please rebase this pull-request to the current head.
After that commit to this branch again and I will review the pr immediately.

@AKMaily
Copy link
Collaborator

AKMaily commented Jan 11, 2024

After reviewing the latest pull request, i think this request is outdated? @R-Abbasi

@R-Abbasi
Copy link
Collaborator Author

Yes, it's not required anymore and should be removed/closed, I believe.

@AKMaily AKMaily closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants