Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing CL arguments, signal handling and tool buttons design #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

R-Abbasi
Copy link
Collaborator

  • Preserved the Suche Geräte button output on Terminal
  • Added interrupting signal handler for ctrl+c
  • Handled flag -l / --ls to output devices UUID merely
  • Handled flag -c to output all devices data
  • Handled flag -o to pipe all devices data into an existing .csv file
  • Handled flag -t to output all devices data during a given time
  • Arranged the size of buttons start, stop, Fortsetzen and Zurücksetzen to fit other tool buttons' size, and more ...

@R-Abbasi R-Abbasi requested a review from MaxClerkwell January 18, 2024 07:01
@AKMaily AKMaily self-requested a review January 19, 2024 10:46
@MaxClerkwell
Copy link
Contributor

I am sorry for the confusion, but the Commandline-Tool should be in a separate Repository.

@R-Abbasi
Copy link
Collaborator Author

Isn't the feature meant to work with the OmniView project, please?

@MaxClerkwell
Copy link
Contributor

It is meant to work with the project. But it is supposed to be a standalone CLI application, that can be used to debug a scope, find all attached scopes and measure a waveform with a specific scope that is attached

@R-Abbasi
Copy link
Collaborator Author

R-Abbasi commented Jan 26, 2024

That sounds great.
Tried to make enough changes in relevant files to get parsing command line arguments - the way wanted in the task - to work well, and it did on my side.
So the pr is not going to be merged nor dies it need more changes but is going to be used as, say, a base in a separate repo for general use, right, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants