-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the Bootstrap feature to the CLI #1789
Open
nluaces
wants to merge
12
commits into
skupperproject:v2
Choose a base branch
from
nluaces:bootstrap-cli
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nluaces
force-pushed
the
bootstrap-cli
branch
from
November 18, 2024 12:03
3031872
to
ce769c1
Compare
c-kruse
reviewed
Nov 18, 2024
fgiorgetti
reviewed
Nov 18, 2024
…e bootstrap script. update README file
nluaces
force-pushed
the
bootstrap-cli
branch
from
November 20, 2024 13:38
2ca34e5
to
e060634
Compare
…ad CMD. adapt bootstrap script
… the system setup command based on the bootstrap former definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands:
startsetupstartsetup -f)(replaces remove.sh script)The bootstrap logic was moved to
pkg/nonkube/bootstrap
. I'm open to move those files to new locations or any kind of renaming that makes more sense.Other updates:
remove.sh andbootstrap.goskupper-cli image