Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Indonesian translation #2018

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Add Indonesian translation #2018

merged 2 commits into from
Sep 20, 2023

Conversation

abazure
Copy link
Contributor

@abazure abazure commented Sep 18, 2023

❗ Please review the guidelines for contributing

Description

Add Indonesian translation for jadx-gui

@skylot
Copy link
Owner

skylot commented Sep 20, 2023

@roniragilimankhoirul thanks 👍

Although, looks like jadx not correctly handle old/obsolete language codes conversion done by Java Locale class.
I commit a fix to always use new codes taken from toLanguageTag method.

For details check docs https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Locale.html:

Legacy language codes
Locale's constructor has always converted three language codes to their earlier, obsoleted forms: he maps to iw, yi maps to ji, and id maps to in. This continues to be the case, in order to not break backwards compatibility.
The APIs added in 1.7 map between the old and new language codes, maintaining the old codes internal to Locale (so that getLanguage and toString reflect the old code), but using the new codes in the BCP 47 language tag APIs (so that toLanguageTag reflects the new one). This preserves the equivalence between Locales no matter which code or API is used to construct them.

@skylot skylot merged commit 8f0d0e4 into skylot:master Sep 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants