Update to Mapping-IO 0.5 #2029
Merged
Update to Mapping-IO 0.5 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylot
approved these changes
Oct 9, 2023
|
@NebelNidas thanks for update!
wow, you really made a lot of PRs, great work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in June you said
mappings-io project activity is very unstable. I couldn't accept that, so I bombarded the repo with all the bug fixes and new features I could think of 😄 This and some other IRL stuff are the reasons why I haven't replied to your responses on some of my issues yet, I'll do that as soon as possible.Anyway, 0.5 turned out to be a pretty huge update, and since I'm now quite familiar with the library, I decided to PR the update directly (despite the contribution guidelines advising against this, I know). I'm looking forward to fixing some of the other pending issues soon, so it's better to have the update now instead of later :)