Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gradle export for APKs without strings.xml #2050

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

nitram84
Copy link
Contributor

@nitram84 nitram84 commented Dec 2, 2023

When I try to export this APK (https://python-helper.apk.gold/) as gradle project, I'm getting the same exception like in #2044 , #1920 and #1918

java.lang.IllegalStateException
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at jadx.core.export.ExportGradleTask.lambda$run$3(ExportGradleTask.java:58)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at jadx.core.export.ExportGradleTask.run(ExportGradleTask.java:55)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

The gradle export always expects a strings.xml, but this assumption isn't true, so my proposition is to postpone this check. I'm sure this PR fixes will also fix #1920.

@skylot skylot merged commit 1e57e85 into skylot:master Dec 3, 2023
5 checks passed
@skylot
Copy link
Owner

skylot commented Dec 3, 2023

@nitram84 thanks!

@nitram84 nitram84 deleted the gradle_export_missing_strings_xml branch March 18, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException
2 participants