feat: improve search bar behavior when using key bindings #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the search bar would toggle, which was quite annoying. Now, it replicates IntelliJ's search bar behaviour. 1.1. If the user has selected text, use that as the search text 1.2. Otherwise, use the previous search text (or empty if none) 2. Select all text in the search bar and give it focus
iscle
commented
Dec 31, 2023
| searchField.selectAll(); | ||
| searchField.requestFocus(); |
There was a problem hiding this comment.
This line was changed so that we don't request focus before having all the text selected (for fast keyboard users :P)
skylot
approved these changes
Jan 5, 2024
|
@iscle thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the search bar would toggle when using the key binding to trigger it (Ctrl + f), which was quite annoying. Now, it replicates IntelliJ's search bar behaviour.
1.1. If the user has selected text, use that as the search text
1.2. Otherwise, use the previous search text (or empty if none)
2. Select all text in the search bar and give it focus