Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indents for namespace declarations #2114

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add indents for namespace declarations #2114

merged 1 commit into from
Mar 1, 2024

Conversation

bagipro
Copy link
Collaborator

@bagipro bagipro commented Mar 1, 2024

Jadx generated invalid XML because of missing spaces, e.g.:

<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="20053842" android:versionName="3.0.609145868" android:compileSdkVersion="34" android:compileSdkVersionCodename="VanillaIceCream" package="com.google.android.apps.adwords" platformBuildVersionCode="34" platformBuildVersionName="VanillaIceCream"xmlns:ns1="http://schemas.android.com/apk/distribution"  ns1:requiredSplitTypes="base__abi"xmlns:ns2="http://schemas.android.com/apk/distribution"  ns2:splitTypes="">

@skylot skylot merged commit 2fdd496 into master Mar 1, 2024
5 checks passed
@skylot skylot deleted the fix_ns_decl branch March 1, 2024 16:32
@skylot
Copy link
Owner

skylot commented Mar 1, 2024

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylot skylot skylot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagipro @skylot