Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update tlds #2320

Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore: update tlds #2320

merged 1 commit into from
Oct 25, 2024

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Oct 24, 2024

No description provided.

@skylot
Copy link
Owner

skylot commented Oct 25, 2024

@pubiqq looks good to me 👍
One thing: previous implementation were also forbid rename of any subpackage and was more like allowed package names. Now it is working only for root packages, this way it is closer to original intention, but this might affect someone use case.

Related to #1369.

@skylot skylot merged commit 688dea0 into skylot:master Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylot skylot skylot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pubiqq @skylot