Skip to content

Commit

Permalink
Enhance smoke tests for managed jobs by adding command to wait for jo…
Browse files Browse the repository at this point in the history
…b status. This update improves the reliability of the test by ensuring the job is in a RUNNING state before proceeding with log synchronization.
  • Loading branch information
KeplerC committed Jan 7, 2025
1 parent ca8578f commit 9518056
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tests/smoke_tests/test_managed_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,11 @@ def test_managed_jobs_logs_sync_down():
'test-managed-jobs-logs-sync-down',
[
f'sky jobs launch -n {name} -y examples/managed_job.yaml -d',
smoke_tests_utils.
get_cmd_wait_until_managed_job_status_contains_matching_job_name(
job_name=f'{name}',
job_status=[sky.ManagedJobStatus.RUNNING],
timeout=300 + smoke_tests_utils.BUMP_UP_SECONDS),
f'sky jobs logs --controller 1 --sync-down',
f'sky jobs logs 1 --sync-down',
f'sky jobs logs --controller --name minimal --sync-down',
Expand Down

0 comments on commit 9518056

Please sign in to comment.