Add error message for rsync not found in image #2250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes #1603 by adding an error message that indicates rsync is not found in the specified image, so that users don't need to dive deep into SkyPilot code to figure out why.
#1641 and #1910 will add cloud-init support for GCP and Azure. After these two are merged, we could have a new PR to add the installation of rsync.
An example of the error message:
Tested (run the relevant ones):
bash format.sh
sky launch --cloud gcp --image-id <some image without rsync>
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh