support filter flag for buildkite #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/smoke-test managed_jobs |
|
/quicktest-core |
Michaelvll
reviewed
Jan 6, 2025
Michaelvll
reviewed
Jan 7, 2025
.buildkite/generate_pipeline.py
Outdated
Comment on lines
81
to
82
| output = subprocess.run(cmd, shell=True, capture_output=True, text=True) | ||
| matches = re.findall('Collected (.+?) with marks: \[(.*?)\]', output.stdout) |
There was a problem hiding this comment.
Why don't we directly pass the flag to the cmd run and let pytest figure out the tests to run?
There was a problem hiding this comment.
Pytest doesn't print filtered tests; it prints all tests. Besides, I need the mark, but pytest doesn't print it.
There was a problem hiding this comment.
@Michaelvll if you are asking why we need to extract the test list at all, instead of just letting pytest figure it out at test time, it's described in the docstring
Michaelvll
approved these changes
Jan 8, 2025
|
/smoke-test managed_jobs |
|
/smoke-test managed_jobs |
|
/smoke-test managed_jobs,serve |
|
/smoke-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support
So that we can configure Buildkite to call this script with this flag, supporting arbitrary pytest flags.
Now we can comment on PR:
/smoke-testto trigger all smoke tests./smoke-test managed_jobsto trigger smoke tests marked by certain pytest mark./smoke-test <mark1>,<mark2>Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh