Queue-based services - add missing sleeps based on queue #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanv
reviewed
Jan 21, 2025
| if next_recurring_api is not None: | ||
| dt = ( | ||
| next_recurring_api.next_call | ||
| - datetime.now(timezone.utc).replace(tzinfo=None) |
There was a problem hiding this comment.
Can you re-use now here? Then you also shouldn't need the negativity check.
There was a problem hiding this comment.
In fact, you should be able to simply calculate sleep_time directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we edit the recurring_apis & reminders services to sleep between each iteration. Essentially, if at the end of every processing loop we do not have anything to process in the next 60 seconds, we sleep 60 seconds. If we do have something to process soon, we only sleep until that time. And if the next entry to process should be processed now, then we do not sleep.
This is based on @stefanv's #5415