Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Don't use importlib.resources.files as a context manager #639

Merged
merged 1 commit into from
Dec 10, 2024
Merged

MAINT: Don't use importlib.resources.files as a context manager #639

merged 1 commit into from
Dec 10, 2024

Conversation

rrjbca
Copy link
Contributor

@rrjbca rrjbca commented Dec 10, 2024

Description

In Python 3.13 the use of PosixPath objects as context managers is deprecated. Update the use of importlib.resources.files, storing the output to a variable instead.

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request

@rrjbca rrjbca added enhancement Improvement of existing feature infrastructure python labels Dec 10, 2024
@rrjbca rrjbca requested a review from a team December 10, 2024 15:39
@rrjbca rrjbca merged commit 560d950 into skypyproject:main Dec 10, 2024
5 checks passed
@rrjbca rrjbca deleted the resources_no_context branch December 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement of existing feature infrastructure python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rrjbca