Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version manifest hash and version details hash to version_manifest.json #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WinPlay02
Copy link

Fixes #4

Also for consistency (otherwise updating would unexpected stuff):

  • Put two manifests to their correct location
  • rename b1.9-pre4-1440 to b1.9-pre4-201110131440

…t.json

Drive-by fixes: Put two manifests to their correct location and rename b1.9-pre4-1440 to b1.9-pre4-201110131440
@WinPlay02 WinPlay02 marked this pull request as ready for review July 10, 2024 17:10
@skyrising
Copy link
Owner

The idea of version_manifest.json was to be compatible with the https://piston-meta.mojang.com/mc/game/version_manifest.json format.

Are there any launchers or tools which accept custom manifests, but require the sha1? It's normally only found in https://piston-meta.mojang.com/mc/game/version_manifest_v2.json

detailsHash shouldn't be a thing. Tools consuming mc-versions should not cache based on it (either use HTTP caching headers when pulling from GitHub pages or, better, clone the repository), so it wouldn't have a use.

I'm not a big fan of adding 2000 lines to a file that changes every commit. (git has to store every version)

@WinPlay02
Copy link
Author

The idea of version_manifest.json was to be compatible with the https://piston-meta.mojang.com/mc/game/version_manifest.json format.

I see. I was thinking of the v2 manifest from mojang, you mentioned, which contains these hashes.

Are there any launchers or tools which accept custom manifests, but require the sha1? It's normally only found in https://piston-meta.mojang.com/mc/game/version_manifest_v2.json

I'm not aware of any launcher which requires this, but it would make detecting stale information (and verifying integrity) a lot easier. In my particular case, the tool would be gitcraft.

detailsHash shouldn't be a thing. Tools consuming mc-versions should not cache based on it (either use HTTP caching headers when pulling from GitHub pages or, better, clone the repository), so it wouldn't have a use.

I'm not a big fan of adding 2000 lines to a file that changes every commit. (git has to store every version)

Should this PR be continued with only the sha1 field? Otherwise, I'd just close it then. Nevertheless, thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versions manifest sha1 to generated version_manifest.json
2 participants