Fix code block creation without block ID (#41)

slack-php · Dec 5, 2024 · d489778 · d489778
1 parent 57024db
commit d489778
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/Blocks/Virtual/VirtualBlock.php b/src/Blocks/Virtual/VirtualBlock.php
@@ -26,7 +26,8 @@ public function getIterator(): Traversable
     {
         $blocks = parent::getIterator();
         if ($this->blockId === null) {
-            return $blocks;
+            yield from $blocks;
+            return;
         }
 
         $index = 1;

diff --git a/tests/Functional/CreateTest.php b/tests/Functional/CreateTest.php
@@ -82,6 +82,9 @@ public function testCreatedVirtualComponentsMatchExpectedOutputJson(): void
                     my code
                     CODE,
                 ),
+                Kit::codeBlock(
+                    code: 'Code block without blockId'
+                )
             ],
         );
 

diff --git a/tests/Functional/assets/create/virtual-blocks.json b/tests/Functional/assets/create/virtual-blocks.json
@@ -71,6 +71,13 @@
                 "type": "mrkdwn",
                 "text": "```\nThis is\nmy code\n```"
             }
+        },
+        {
+            "type": "section",
+            "text": {
+                "type": "mrkdwn",
+                "text": "```\nCode block without blockId\n```"
+            }
         }
     ]
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                         my code
                         CODE,
                     ),
+                    Kit::codeBlock(
+                        code: 'Code block without blockId'
+                    )
                 ],
             );
@@ Expand Down @@