Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude spec files from gem package #525

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Exclude spec files from gem package #525

merged 1 commit into from
Aug 3, 2024
+2 −1

Conversation

amatsuda
Copy link
Contributor

@amatsuda amatsuda commented Aug 2, 2024

Here's a patch that excludes files under spec directory from the gem package.

With this patch, the gem package size shrinks as follows:

before: 355840 bytes
after:  293376 bytes

@dangerpr-bot
Copy link

dangerpr-bot commented Aug 2, 2024 •
edited
Loading

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@amatsuda amatsuda force-pushed the exclude_specs_from_gem_package branch 2 times, most recently from fad205f to 4813782 Compare August 2, 2024 11:08
@coveralls
Copy link

coveralls commented Aug 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10222561379

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.322%
Totals Coverage Status
Change from base Build 9930936896: 0.0%
Covered Lines: 5387
Relevant Lines: 6031
💛 - Coveralls

dblock
dblock requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see below.

CHANGELOG.md Show resolved Hide resolved
@amatsuda amatsuda force-pushed the exclude_specs_from_gem_package branch from 4813782 to 6399bcd Compare August 2, 2024 22:01
@dblock dblock merged commit 56995cc into slack-ruby:master Aug 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amatsuda @dangerpr-bot @coveralls @dblock