Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify dependency on logger #530

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Specify dependency on logger #530

merged 1 commit into from
Jan 14, 2025

Conversation

rwstauner
Copy link
Contributor

It's moving from the stdlib to a gem in ruby 3.5:
ruby/ruby@cda268d

@dangerpr-bot
Copy link

dangerpr-bot commented Jan 14, 2025

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

It's moving from the stdlib to a gem in ruby 3.5:
ruby/ruby@cda268d
@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12774165275

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.336%

Totals Coverage Status
Change from base Build 12106262175: 0.0%
Covered Lines: 5395
Relevant Lines: 6039

💛 - Coveralls

rwstauner added a commit to Shopify/yjit-metrics that referenced this pull request Jan 14, 2025
@dblock dblock merged commit c75d8e4 into slack-ruby:master Jan 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants