Change tarball location to github in Dockerfile #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to where the tarball for BMAD distribution is retrieved from.
All other steps have been kept the same as before, I can send the image via slack (Github doesn't support .tar file 😢 or files over >25MB) containing the resulting image of
docker build -t simulacrum .
so you don't have to waste 2 hours building BMAD again 😄To Open Image:
docker load < simulacrum.zip
Alternatively, build the image from scratch
MattKing06/111_bmad_tarballs_moved_to_github
)docker build -t simulacrum .
in the top-level directory where the Dockerfile isdocker run -it simulacrum:latest .
Notes
There were some changes to lcls-tools repo that mean some of those modules are in a different structure now, so I have opened a new issue to fix that as well.
EDIT: Turns out none of the modules here were affected by the reorg of lcls-tools